Robustness improvements on pmproxy connection setup, server side.
Several changes to same section of code:
When reporting errors, use __pmNotifyErr for logging errors, so
we have timestamps in the logs.
Initialise the per-client pmcd_fd field to a negative value in
the setup code, early-on. Otherwise when we call DeleteClient,
we may close some random unrelated file descriptor. Its highly
likely that this is the cause of the running-but-not-listening
pmproxy problem.
User send/recv for socket operations so this code will work on
Windows as well.
Improve error reporting when partially setup connections fail,
in particular the host/port string - if no host received, do not
attempt to decode the (non-existent) port, report the host error.
Robustness improvements on pmproxy connection setup, server side.
Several changes to same section of code:
we have timestamps in the logs.
the setup code, early-on. Otherwise when we call DeleteClient,
we may close some random unrelated file descriptor. Its highly
likely that this is the cause of the running-but-not-listening
pmproxy problem.
Windows as well.
in particular the host/port string - if no host received, do not
attempt to decode the (non-existent) port, report the host error.