Project

General

Profile

« Previous | Next » 

Revision 7c8c1d38

Added by Nathan Scott almost 16 years ago

  • ID 7c8c1d387af7d9f8c82765407d14bec683970d8d

Correct a logic error in pmlogger_daily scripts detection of running
pmloggers. This recently regressed even more but was actually never
right. Funnily enough, the same logic exists in pmlogger_check and
it is right - so, this just dups that exact logic here. The root
issue is to do with handling of failed glob-expansion on the process
id files below /var/log/pmlogger.

Symptoms of the problem are:

  • failure to rotate daily logs for non-primary pmloggers, and
  • email messages with diagnostics along the lines: pmlogger_daily: Error: no pmlogger instance running for host "fw1" [/var/lib/pcp/config/pmlogger/control:28] ... logging for host "fw1" unchanged pmlogger_daily: Error: no pmlogger instance running for host "fw2" [/var/lib/pcp/config/pmlogger/control:29] ... logging for host "fw2" unchanged
  • added
  • modified
  • copied
  • renamed
  • deleted